Commit graph

1188 commits

Author SHA1 Message Date
sthibaul
19ee48869f Merge branch 'coverity' into 'master'
coverity misc fixes

See merge request l2tpns/l2tpns!18
2022-11-05 22:27:07 +00:00
Dominique Martinet
c770205890 pppoe_sess_send: check packet length before reading header
if the packet is too small then reading pack + ETH_HLEN is invalid, first
check that the packet is big enough then read the header at an offset we
know is valid

Reported-by: Coverity#375305
2022-11-05 21:35:53 +09:00
Dominique Martinet
54be500888 bgp_write: fix sent data (offset) on partial write
&peer->outbuf->packet has a non-1 size, so &foo + offset would
incorrectly offset by sizeof(packet) * offset, while it is meant as a
byte offset.

Cast to char * to have a simple offset.

Reported-by: Coverity#375309
2022-11-05 21:29:02 +09:00
Dominique Martinet
bbedc40bf2 sendarp: fix out of bound read on mac address
mac address is only 6 bytes, which we specify in sll_halen, so do not try to
read more than that into sll_addr.

Reported-by: Coverity#375313
2022-11-05 21:25:31 +09:00
Dominique Martinet
af92de5eeb processudp: fix memory leak
send/recvchalresponse should be freed before early returns in the function,
as there are code paths where they would be allocated before these.

Note free is no-op on null pointer so checking for non-null value is useless.

Reported-by: Coverity#375342
2022-11-05 21:18:36 +09:00
Samuel Thibault
4d906e595d Fix liveness of buf
So that domain can point to it.
2022-11-03 13:27:54 +01:00
Samuel Thibault
6df96f8148 Fix duplicate close 2022-11-03 13:23:59 +01:00
Samuel Thibault
7623522726 Avoid warning
The restart code is indeed only needed for reset cases, any other case
doesn't need anything there.
2022-11-03 11:51:43 +01:00
Samuel Thibault
92733074db Fix state name
Dead and Initial happen to both equal 0, so this is actually a
no-behavior-change.
2022-11-03 11:50:39 +01:00
Samuel Thibault
fbf0c191e1 Fix operator priority
(notably ternary ?: is less prioritized than <=)
2022-11-03 11:50:04 +01:00
Samuel Thibault
233f7e8526 Drop useless test 2022-11-03 11:49:48 +01:00
Samuel Thibault
7124084434 Fix alarm management 2022-11-03 11:33:50 +01:00
Samuel Thibault
a612c24207 Add missing +x perm 2022-11-03 11:30:22 +01:00
Sebastien Badia
d1536bdcfb
New release: 2.4.1 2022-09-03 01:10:37 +02:00
Sebastien Badia
48e7ef75b7
ci: test L2TPNS version (Ref #11) 2022-08-24 13:16:43 +02:00
Samuel Thibault
ab58da4056 Reduce loglevel of warning
Various clients are making the same mistake, let's not flood our own
logs with errors that are actually from the client.

Ref #10
2022-07-13 11:18:50 +02:00
Sebastien Badia
e9afb88de7
New release: 2.4.0 2022-07-03 23:17:59 +02:00
sebian
5e8cf3660c Merge branch 'set-secret-detection-config-1' into 'master'
Configure Secret Detection in `.gitlab-ci.yml`, creating this file if it does not already exist

See merge request l2tpns/l2tpns!17
2022-07-03 20:52:26 +00:00
sebian
bb56dd7987 Configure Secret Detection in .gitlab-ci.yml, creating this file if it does not already exist 2022-07-03 20:50:42 +00:00
sebian
6053b0d23d Merge branch 'set-sast-config-1' into 'master'
Configure SAST in `.gitlab-ci.yml`, creating this file if it does not already exist

See merge request l2tpns/l2tpns!16
2022-07-03 20:50:19 +00:00
sebian
7e5d8afaf5 Configure SAST in .gitlab-ci.yml, creating this file if it does not already exist 2022-07-03 20:47:34 +00:00
sebian
40a02aa8d5 Merge branch '64bit' into 'master'
Use 64bit counters for accounting

Closes #12

See merge request l2tpns/l2tpns!13
2022-07-02 12:16:54 +00:00
sebian
5317b7aca6 Merge branch 'default_radius_port' into 'master'
Use newer radius port 1812 by default

See merge request l2tpns/l2tpns!15
2022-07-02 12:15:30 +00:00
sebian
955b079395 Merge branch 'cli_localhost' into 'master'
Make cli bound to localhost in default configuration

See merge request l2tpns/l2tpns!14
2022-07-02 12:13:41 +00:00
Samuel Thibault
71a60411a1 Use newer radius port 1812 by default
1645 has been marked as "old-radius" for a long time.
2022-05-28 09:33:05 +02:00
Samuel Thibault
41c0bd1bc7 Make cli bound to localhost in default configuration
Even if the default users file is empty, it's still better to avoid
exposing by default a service to the wide internet...
2022-05-26 14:07:56 +02:00
Samuel Thibault
f9e2045b38 Add example for IPv6 DNS servers 2022-05-26 13:23:46 +02:00
Samuel Thibault
31dedbbe66 Use 64bit counters for accounting
Otherwise with 5-minute reporting we overflow with >= ~100Mbps.

Fixes #12
2022-01-24 00:40:26 +01:00
Dominique Rousseau
7c715f16fc fix bgp_add_route with bind_address ( fix #9 ) 2021-10-15 21:55:31 +02:00
Baptiste Jonglez
832945bb4b Fix reported l2tpns version number 2021-10-15 21:55:31 +02:00
sthibaul
1e5573679c Merge branch 'fix-ppoe-buffer-overflow' into 'master'
Buffer overflow on show sesion pppoe and on pppoe discover LOG level 3.

See merge request l2tpns/l2tpns!12
2021-08-23 18:10:09 +00:00
Fernando ALVES
dd98adf3e2 Buffer overflow on show sesion pppoe and on pppoe discover LOG level 3. 2021-04-25 13:47:51 +02:00
Julien Rabier
a5ddc0f64a Merge branch 'systemd_restart' into 'master'
systemd: restart l2tpns on failure

See merge request l2tpns/l2tpns!11
2021-03-05 16:08:44 +00:00
Baptiste Jonglez
2da36a071f systemd: restart l2tpns on failure
When a l2tpns cluster gets out of a "split brain" situation, l2tpns will
consider that it is not normal to having multiple master, and some members
of the cluster will voluntarily kill themselves.

While this is probably the best thing to do for l2tpns in this situation,
continued operation is important.  Let's tell systemd to restart l2tpns in
such cases.

Looking at the code, there are several other places where l2tpns might
exit in case of grave failure, and this change will also cover these
cases.
2021-02-14 17:51:58 +01:00
Julien Rabier
a8694ed0bc New upstream version 2.3.3 2021-02-05 14:42:30 +01:00
Julien Rabier
f03d78d012 Merge branch '8-clean-auto-generated-markdown-man-sources' into 'master'
Resolve "Clean auto-generated markdown man sources"

Closes #8

See merge request l2tpns/l2tpns!10
2021-02-05 13:38:12 +00:00
Julien Rabier
f261d4fffe Clean source manpages 2021-02-05 14:35:05 +01:00
Julien Rabier
a8dc396099 Merge branch 'manpages' into 'master'
Manpages fixes

See merge request l2tpns/l2tpns!9
2021-02-04 19:57:30 +00:00
Sebastien Badia
f9ec360e5b
build: Fix manpages location 2021-01-31 23:42:01 +01:00
Sebastien Badia
b45df29dc7
docs: gen-docs - Fix pandoc options and re-generate manpages
Tested with:

  LC_ALL=en_US.UTF-8 MANROFFSEQ='' MANWIDTH=80 man \
  --warnings -E UTF-8 -l -Tutf8 -Z docs/manpages/startup-config.5 > /dev/null
2021-01-31 23:40:56 +01:00
Sebastien Badia
bf1e1d2d8a
docs: man - Fix manpages headers, fix dead links 2021-01-31 23:34:37 +01:00
Julien Rabier
bc2d55725b New release: 2.3.2 2021-01-31 17:35:36 +01:00
Julien Rabier
11d63a0c52 Merge branch '4-convert-docbook-documentation-to-something-more-user-friendly' into 'master'
Resolve "Convert docbook documentation to something more user-friendly"

Closes #4

See merge request l2tpns/l2tpns!7
2021-01-31 16:25:47 +00:00
Julien Rabier
dd5d24fac2 Merge branch 'fix-freeze-infinite-loop' into 'master'
Fix infinite loop error 'Unknown AVP vendor'

See merge request l2tpns/l2tpns!8
2021-01-31 16:25:12 +00:00
Julien Rabier
72609641db Convert docbook documentation to markdown, add build mechanism using pandoc 2021-01-31 17:07:13 +01:00
Fernando ALVES
2d6fe53a7a Fix infinite loop error 'Unknown AVP vendor' 2021-01-17 22:19:01 +01:00
Julien Rabier
db5ff8c356 fix Makefile in order to cross build from source in Debian
fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977569
2020-12-17 10:16:29 +01:00
Julien Rabier
4824735794 New release: 2.3.1 2020-11-07 15:11:48 +01:00
Julien Rabier
33183e1f4b Merge branch 'init_script' into 'master'
Add systemd startup script

See merge request l2tpns/l2tpns!4
2020-11-07 14:45:32 +01:00
Sebastien Badia
fe6a557351
init: Added documentation key on SystemD unit 2020-11-07 14:43:59 +01:00