experiments/clixon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed: [CLI show config | display <format> exits over mountpoints with large YANGs](https://github.com/clicon/clixon-controller/issues/39)

Browse source
This commit is contained in:
Olof hagsand 2023-09-16 15:48:24 +02:00
parent 4730082d7b
commit 35ad68fa70
2 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
CHANGELOG.md
View file

@ -85,10 +85,12 @@ Developers may need to change their code
### Corrected Bugs ### Corrected Bugs
* Fixed: [CLI show config | display <format> exits over mountpoints with large YANGs](https://github.com/clicon/clixon-controller/issues/39)
* No need to bind for xml and json, only cli and text
* Fixed several issues with extra-config files, including overwriting of structured sub-configs * Fixed several issues with extra-config files, including overwriting of structured sub-configs
* including `<restconf>`and m̀ <autoconf>` * including `<restconf>`and m̀ <autoconf>`
* [YANG error when poking on EOS configuration](https://github.com/clicon/clixon-controller/issues/26) * Fixed: [YANG error when poking on EOS configuration](https://github.com/clicon/clixon-controller/issues/26)
* [CLICON_CONFIGDIR with external subsystems causes endless looping](https://github.com/clicon/clixon/issues/439) * Fixed: [CLICON_CONFIGDIR with external subsystems causes endless looping](https://github.com/clicon/clixon/issues/439)
* Fixed: ["show configuration devices" and "show configuration devices | display cli" differs](https://github.com/clicon/clixon-controller/issues/24) * Fixed: ["show configuration devices" and "show configuration devices | display cli" differs](https://github.com/clicon/clixon-controller/issues/24)
* Fixed: [Configuring Juniper PTX produces CLI errors](https://github.com/clicon/clixon-controller/issues/19) * Fixed: [Configuring Juniper PTX produces CLI errors](https://github.com/clicon/clixon-controller/issues/19)
* Fixed: CLI output pipes: Add CLICON_PIPETREE to any cli files, not just the first * Fixed: CLI output pipes: Add CLICON_PIPETREE to any cli files, not just the first

18
apps/cli/cli_pipe.c
View file

@ -294,11 +294,19 @@ pipe_showas_fn(clicon_handle h,
/* Bind module with mtpoints requires h, but parse functions font have h */ /* Bind module with mtpoints requires h, but parse functions font have h */
if (clixon_xml_parse_file(stdin, YB_NONE, yspec, &xt, NULL) < 0) if (clixon_xml_parse_file(stdin, YB_NONE, yspec, &xt, NULL) < 0)
goto done; goto done;
if ((ret = xml_bind_yang(h, xt, YB_MODULE, yspec, &xerr)) < 0) switch (format){
goto done; case FORMAT_CLI:
if (ret == 0){ case FORMAT_TEXT:
clixon_netconf_error(xerr, "Parse top file", NULL); /* Requires binding. Note binding over mountpoints can cause rpc: extra latency */
goto done; if ((ret = xml_bind_yang(h, xt, YB_MODULE, yspec, &xerr)) < 0)
goto done;
if (ret == 0){
clixon_netconf_error(xerr, "Parse top file", NULL);
goto done;
}
break;
default:
break;
} }
switch (format){ switch (format){
case FORMAT_XML: case FORMAT_XML: