diff --git a/CHANGELOG.md b/CHANGELOG.md index 12cf842f..78575006 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -85,10 +85,12 @@ Developers may need to change their code ### Corrected Bugs +* Fixed: [CLI show config | display exits over mountpoints with large YANGs](https://github.com/clicon/clixon-controller/issues/39) + * No need to bind for xml and json, only cli and text * Fixed several issues with extra-config files, including overwriting of structured sub-configs * including ``and m̀ ` -* [YANG error when poking on EOS configuration](https://github.com/clicon/clixon-controller/issues/26) -* [CLICON_CONFIGDIR with external subsystems causes endless looping](https://github.com/clicon/clixon/issues/439) +* Fixed: [YANG error when poking on EOS configuration](https://github.com/clicon/clixon-controller/issues/26) +* Fixed: [CLICON_CONFIGDIR with external subsystems causes endless looping](https://github.com/clicon/clixon/issues/439) * Fixed: ["show configuration devices" and "show configuration devices | display cli" differs](https://github.com/clicon/clixon-controller/issues/24) * Fixed: [Configuring Juniper PTX produces CLI errors](https://github.com/clicon/clixon-controller/issues/19) * Fixed: CLI output pipes: Add CLICON_PIPETREE to any cli files, not just the first diff --git a/apps/cli/cli_pipe.c b/apps/cli/cli_pipe.c index 3cca01c8..08c9b3ed 100644 --- a/apps/cli/cli_pipe.c +++ b/apps/cli/cli_pipe.c @@ -294,11 +294,19 @@ pipe_showas_fn(clicon_handle h, /* Bind module with mtpoints requires h, but parse functions font have h */ if (clixon_xml_parse_file(stdin, YB_NONE, yspec, &xt, NULL) < 0) goto done; - if ((ret = xml_bind_yang(h, xt, YB_MODULE, yspec, &xerr)) < 0) - goto done; - if (ret == 0){ - clixon_netconf_error(xerr, "Parse top file", NULL); - goto done; + switch (format){ + case FORMAT_CLI: + case FORMAT_TEXT: + /* Requires binding. Note binding over mountpoints can cause rpc: extra latency */ + if ((ret = xml_bind_yang(h, xt, YB_MODULE, yspec, &xerr)) < 0) + goto done; + if (ret == 0){ + clixon_netconf_error(xerr, "Parse top file", NULL); + goto done; + } + break; + default: + break; } switch (format){ case FORMAT_XML: