experiments/clixon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Debug: ensured all exit logs are on the format: retval:%s

Browse source
This commit is contained in:
Olof hagsand 2024-01-24 10:03:28 +01:00
parent b89d5e2cde
commit 121cd3ed2e
19 changed files with 32 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/backend/backend_client.c
View file

@ -282,7 +282,7 @@ backend_monitoring_state_get(clixon_handle h,
goto fail; goto fail;
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (cb) if (cb)
cbuf_free(cb); cbuf_free(cb);
return retval; return retval;
@ -1871,7 +1871,7 @@ from_client(int s,
goto done; goto done;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval=%d", retval); clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval);
if (cbce) if (cbce)
cbuf_free(cbce); cbuf_free(cbce);
if (msg) if (msg)

2
apps/backend/backend_confirm.c
View file

@ -369,9 +369,7 @@ schedule_rollback_event(clixon_handle h,
/* error is logged in called function */ /* error is logged in called function */
goto done; goto done;
}; };
retval = 0; retval = 0;
done: done:
return retval; return retval;
} }

2
apps/backend/backend_get.c
View file

@ -373,7 +373,7 @@ get_statedata(clixon_handle h,
} /* switch wdef */ } /* switch wdef */
retval = 1; /* OK */ retval = 1; /* OK */
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (xerr) if (xerr)
xml_free(xerr); xml_free(xerr);
if (x1) if (x1)

2
apps/netconf/netconf_rpc.c
View file

@ -504,7 +504,7 @@ netconf_notification_cb(int s,
ok: ok:
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (cb) if (cb)
cbuf_free(cb); cbuf_free(cb);
if (nsc) if (nsc)

2
apps/restconf/clixon_http_data.c
View file

@ -498,6 +498,6 @@ api_http_data(clixon_handle h,
done: done:
if (path) if (path)
free(path); free(path);
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }

4
apps/restconf/restconf_http1.c
View file

@ -119,7 +119,7 @@ _http1_parse(clixon_handle h,
ok: ok:
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }
@ -463,7 +463,7 @@ restconf_http1_path_root(clixon_handle h,
goto done; goto done;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (subject) if (subject)
free(subject); free(subject);
if (xerr) if (xerr)

2
apps/restconf/restconf_lib.c
View file

@ -861,7 +861,7 @@ restconf_socket_init(const char *netns0,
clixon_debug(CLIXON_DBG_CLIENT, "ss=%d", *ss); clixon_debug(CLIXON_DBG_CLIENT, "ss=%d", *ss);
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }

2
apps/restconf/restconf_main_fcgi.c
View file

@ -124,7 +124,7 @@ fcgi_params_set(clixon_handle h,
} }
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }

2
apps/restconf/restconf_main_native.c
View file

@ -581,7 +581,7 @@ restconf_accept_client(int fd,
goto done; goto done;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "retval %d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (name) if (name)
free(name); free(name);
return retval; return retval;

10
apps/restconf/restconf_native.c
View file

@ -593,7 +593,7 @@ read_ssl(restconf_conn *rc,
} }
retval = 0; retval = 0;
// done: // done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }
@ -913,7 +913,7 @@ restconf_http2_process(restconf_conn *rc,
} }
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }
#endif /* HAVE_LIBNGHTTP2 */ #endif /* HAVE_LIBNGHTTP2 */
@ -1029,7 +1029,7 @@ restconf_connection(int s,
ok: ok:
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "retval %d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} /* restconf_connection */ } /* restconf_connection */
@ -1068,7 +1068,7 @@ restconf_connection_close1(restconf_conn *rc)
} }
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }
@ -1457,7 +1457,7 @@ restconf_ssl_accept_client(clixon_handle h,
*rcp = rc; *rcp = rc;
retval = 1; /* OK, up */ retval = 1; /* OK, up */
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "retval %d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (name) if (name)
free(name); free(name);
return retval; return retval;

4
apps/restconf/restconf_nghttp2.c
View file

@ -346,7 +346,7 @@ restconf_nghttp2_path(restconf_stream_data *sd)
goto done; goto done;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
if (cvv) if (cvv)
cvec_free(cvv); cvec_free(cvv);
if (oneline) if (oneline)
@ -971,7 +971,7 @@ http2_send_server_connection(restconf_conn *rc)
} }
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval);
return retval; return retval;
} }

6
apps/snmp/snmp_lib.c
View file

@ -747,7 +747,7 @@ type_snmp2xml(yang_stmt *ys,
} }
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval);
if (origtype) if (origtype)
free(origtype); free(origtype);
if (cv) if (cv)
@ -836,7 +836,7 @@ type_xml2snmp_pre(char *xmlstr0,
} }
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval);
if (cb) if (cb)
cbuf_free(cb); cbuf_free(cb);
return retval; return retval;
@ -981,7 +981,7 @@ type_xml2snmp(char *snmpstr,
} }
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "%d", retval); clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval);
return retval; return retval;
fail: fail:
retval = 0; retval = 0;

2
lib/src/clixon_netconf_monitoring.c
View file

@ -277,7 +277,7 @@ netconf_monitoring_state_get(clixon_handle h,
} }
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); clixon_debug(CLIXON_DBG_DEFAULT|CLIXON_DBG_DETAIL, "retval:%d", retval);
if (cb) if (cb)
cbuf_free(cb); cbuf_free(cb);
return retval; return retval;

6
lib/src/clixon_netns.c
View file

@ -191,7 +191,7 @@ create_socket(struct sockaddr *sa,
*sock = s; *sock = s;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); clixon_debug(CLIXON_DBG_DEFAULT, "retval:%d", retval);
if (retval != 0 && s != -1) if (retval != 0 && s != -1)
close(s); close(s);
return retval; return retval;
@ -306,7 +306,7 @@ fork_netns_socket(const char *netns,
} }
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); clixon_debug(CLIXON_DBG_DEFAULT, "retval:%d", retval);
return retval; return retval;
} }
#endif /* HAVE_SETNS */ #endif /* HAVE_SETNS */
@ -352,6 +352,6 @@ clixon_netns_socket(const char *netns,
ok: ok:
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); clixon_debug(CLIXON_DBG_DEFAULT, "retval:%d", retval);
return retval; return retval;
} }

4
lib/src/clixon_options.c
View file

@ -293,7 +293,7 @@ parse_configfile_one(clixon_handle h,
xt = NULL; xt = NULL;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s returning %d", filename, retval); clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s retval:%d", filename, retval);
if (xt) if (xt)
xml_free(xt); xml_free(xt);
if (fp) if (fp)
@ -504,7 +504,7 @@ parse_configfile(clixon_handle h,
*xconfig = xt; *xconfig = xt;
xt = NULL; xt = NULL;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s returning %d", filename, retval); clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s retval:%d", filename, retval);
if (dp) if (dp)
free(dp); free(dp);
if (nsc) if (nsc)

2
lib/src/clixon_proto.c
View file

@ -864,7 +864,7 @@ send_msg_notify_xml(clixon_handle h,
goto done; goto done;
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_MSG | CLIXON_DBG_DETAIL, "%d", retval); clixon_debug(CLIXON_DBG_MSG | CLIXON_DBG_DETAIL, "retval:%d", retval);
if (cb) if (cb)
cbuf_free(cb); cbuf_free(cb);
return retval; return retval;

4
lib/src/clixon_proto_client.c
View file

@ -253,7 +253,7 @@ clicon_rpc_msg(clixon_handle h,
} }
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "%d", retval); clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "retval:%d", retval);
if (retdata) if (retdata)
free(retdata); free(retdata);
if (xret) if (xret)
@ -1105,7 +1105,7 @@ clicon_rpc_get2(clixon_handle h,
} }
retval = 0; retval = 0;
done: done:
clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "%d", retval); clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "retval:%d", retval);
if (nscd) if (nscd)
cvec_free(nscd); cvec_free(nscd);
if (cb) if (cb)

2
lib/src/clixon_yang_module.c
View file

@ -395,7 +395,7 @@ yang_modules_state_get(clixon_handle h,
} }
retval = 1; retval = 1;
done: done:
clixon_debug(CLIXON_DBG_YANG, "%d", retval); clixon_debug(CLIXON_DBG_YANG, "retval:%d", retval);
if (xvec) if (xvec)
free(xvec); free(xvec);
if (cb) if (cb)