diff --git a/apps/backend/backend_client.c b/apps/backend/backend_client.c index 459aa146..887653ce 100644 --- a/apps/backend/backend_client.c +++ b/apps/backend/backend_client.c @@ -282,7 +282,7 @@ backend_monitoring_state_get(clixon_handle h, goto fail; retval = 1; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (cb) cbuf_free(cb); return retval; @@ -1871,7 +1871,7 @@ from_client(int s, goto done; retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval=%d", retval); + clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval); if (cbce) cbuf_free(cbce); if (msg) diff --git a/apps/backend/backend_commit.c b/apps/backend/backend_commit.c index ffe2a437..00900e54 100644 --- a/apps/backend/backend_commit.c +++ b/apps/backend/backend_commit.c @@ -1102,7 +1102,7 @@ load_failsafe(clixon_handle h, } clixon_log(h, LOG_NOTICE, "%s failed, Failsafe database loaded ", phase); retval = 0; - done: + done: if (cbret) cbuf_free(cbret); return retval; diff --git a/apps/backend/backend_confirm.c b/apps/backend/backend_confirm.c index d902e650..52634d5f 100644 --- a/apps/backend/backend_confirm.c +++ b/apps/backend/backend_confirm.c @@ -369,10 +369,8 @@ schedule_rollback_event(clixon_handle h, /* error is logged in called function */ goto done; }; - retval = 0; - - done: + done: return retval; } diff --git a/apps/backend/backend_get.c b/apps/backend/backend_get.c index be1fcb79..0dcad562 100644 --- a/apps/backend/backend_get.c +++ b/apps/backend/backend_get.c @@ -373,7 +373,7 @@ get_statedata(clixon_handle h, } /* switch wdef */ retval = 1; /* OK */ done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (xerr) xml_free(xerr); if (x1) diff --git a/apps/netconf/netconf_rpc.c b/apps/netconf/netconf_rpc.c index b0b8f432..44ef226e 100644 --- a/apps/netconf/netconf_rpc.c +++ b/apps/netconf/netconf_rpc.c @@ -504,7 +504,7 @@ netconf_notification_cb(int s, ok: retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (cb) cbuf_free(cb); if (nsc) diff --git a/apps/restconf/clixon_http_data.c b/apps/restconf/clixon_http_data.c index e1f9c084..426c5946 100644 --- a/apps/restconf/clixon_http_data.c +++ b/apps/restconf/clixon_http_data.c @@ -498,6 +498,6 @@ api_http_data(clixon_handle h, done: if (path) free(path); - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } diff --git a/apps/restconf/restconf_http1.c b/apps/restconf/restconf_http1.c index 1148e46c..47ac9730 100644 --- a/apps/restconf/restconf_http1.c +++ b/apps/restconf/restconf_http1.c @@ -119,7 +119,7 @@ _http1_parse(clixon_handle h, ok: retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } @@ -463,7 +463,7 @@ restconf_http1_path_root(clixon_handle h, goto done; retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (subject) free(subject); if (xerr) diff --git a/apps/restconf/restconf_lib.c b/apps/restconf/restconf_lib.c index aca13889..e83852f9 100644 --- a/apps/restconf/restconf_lib.c +++ b/apps/restconf/restconf_lib.c @@ -861,7 +861,7 @@ restconf_socket_init(const char *netns0, clixon_debug(CLIXON_DBG_CLIENT, "ss=%d", *ss); retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } diff --git a/apps/restconf/restconf_main_fcgi.c b/apps/restconf/restconf_main_fcgi.c index 713b11b8..d299cb92 100644 --- a/apps/restconf/restconf_main_fcgi.c +++ b/apps/restconf/restconf_main_fcgi.c @@ -124,7 +124,7 @@ fcgi_params_set(clixon_handle h, } retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } diff --git a/apps/restconf/restconf_main_native.c b/apps/restconf/restconf_main_native.c index b76c2ab2..c05daad7 100644 --- a/apps/restconf/restconf_main_native.c +++ b/apps/restconf/restconf_main_native.c @@ -581,7 +581,7 @@ restconf_accept_client(int fd, goto done; retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "retval %d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (name) free(name); return retval; diff --git a/apps/restconf/restconf_native.c b/apps/restconf/restconf_native.c index 18d0357d..7d349fbb 100644 --- a/apps/restconf/restconf_native.c +++ b/apps/restconf/restconf_native.c @@ -593,7 +593,7 @@ read_ssl(restconf_conn *rc, } retval = 0; // done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } @@ -913,7 +913,7 @@ restconf_http2_process(restconf_conn *rc, } retval = 1; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } #endif /* HAVE_LIBNGHTTP2 */ @@ -1029,7 +1029,7 @@ restconf_connection(int s, ok: retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "retval %d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } /* restconf_connection */ @@ -1068,7 +1068,7 @@ restconf_connection_close1(restconf_conn *rc) } retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } @@ -1457,7 +1457,7 @@ restconf_ssl_accept_client(clixon_handle h, *rcp = rc; retval = 1; /* OK, up */ done: - clixon_debug(CLIXON_DBG_CLIENT, "retval %d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (name) free(name); return retval; diff --git a/apps/restconf/restconf_nghttp2.c b/apps/restconf/restconf_nghttp2.c index fa40cbcc..4326882a 100644 --- a/apps/restconf/restconf_nghttp2.c +++ b/apps/restconf/restconf_nghttp2.c @@ -346,7 +346,7 @@ restconf_nghttp2_path(restconf_stream_data *sd) goto done; retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); if (cvv) cvec_free(cvv); if (oneline) @@ -971,7 +971,7 @@ http2_send_server_connection(restconf_conn *rc) } retval = 0; done: - clixon_debug(CLIXON_DBG_CLIENT, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT, "retval:%d", retval); return retval; } diff --git a/apps/snmp/snmp_lib.c b/apps/snmp/snmp_lib.c index 9a8a6078..34f27a33 100644 --- a/apps/snmp/snmp_lib.c +++ b/apps/snmp/snmp_lib.c @@ -747,7 +747,7 @@ type_snmp2xml(yang_stmt *ys, } retval = 1; done: - clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval); if (origtype) free(origtype); if (cv) @@ -836,7 +836,7 @@ type_xml2snmp_pre(char *xmlstr0, } retval = 1; done: - clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval); if (cb) cbuf_free(cb); return retval; @@ -981,7 +981,7 @@ type_xml2snmp(char *snmpstr, } retval = 1; done: - clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "%d", retval); + clixon_debug(CLIXON_DBG_CLIENT | CLIXON_DBG_DETAIL, "retval:%d", retval); return retval; fail: retval = 0; diff --git a/lib/src/clixon_netconf_monitoring.c b/lib/src/clixon_netconf_monitoring.c index 567af659..876a7f09 100644 --- a/lib/src/clixon_netconf_monitoring.c +++ b/lib/src/clixon_netconf_monitoring.c @@ -277,7 +277,7 @@ netconf_monitoring_state_get(clixon_handle h, } retval = 1; done: - clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); + clixon_debug(CLIXON_DBG_DEFAULT|CLIXON_DBG_DETAIL, "retval:%d", retval); if (cb) cbuf_free(cb); return retval; diff --git a/lib/src/clixon_netns.c b/lib/src/clixon_netns.c index 4b7d94f6..9b711244 100644 --- a/lib/src/clixon_netns.c +++ b/lib/src/clixon_netns.c @@ -191,7 +191,7 @@ create_socket(struct sockaddr *sa, *sock = s; retval = 0; done: - clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); + clixon_debug(CLIXON_DBG_DEFAULT, "retval:%d", retval); if (retval != 0 && s != -1) close(s); return retval; @@ -306,7 +306,7 @@ fork_netns_socket(const char *netns, } retval = 0; done: - clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); + clixon_debug(CLIXON_DBG_DEFAULT, "retval:%d", retval); return retval; } #endif /* HAVE_SETNS */ @@ -352,6 +352,6 @@ clixon_netns_socket(const char *netns, ok: retval = 0; done: - clixon_debug(CLIXON_DBG_DEFAULT, "%d", retval); + clixon_debug(CLIXON_DBG_DEFAULT, "retval:%d", retval); return retval; } diff --git a/lib/src/clixon_options.c b/lib/src/clixon_options.c index fbdcab9c..e16ac646 100644 --- a/lib/src/clixon_options.c +++ b/lib/src/clixon_options.c @@ -293,7 +293,7 @@ parse_configfile_one(clixon_handle h, xt = NULL; retval = 0; done: - clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s returning %d", filename, retval); + clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s retval:%d", filename, retval); if (xt) xml_free(xt); if (fp) @@ -504,7 +504,7 @@ parse_configfile(clixon_handle h, *xconfig = xt; xt = NULL; done: - clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s returning %d", filename, retval); + clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "Done w/ config file %s retval:%d", filename, retval); if (dp) free(dp); if (nsc) diff --git a/lib/src/clixon_proto.c b/lib/src/clixon_proto.c index 60fed521..e17ecc8e 100644 --- a/lib/src/clixon_proto.c +++ b/lib/src/clixon_proto.c @@ -864,7 +864,7 @@ send_msg_notify_xml(clixon_handle h, goto done; retval = 0; done: - clixon_debug(CLIXON_DBG_MSG | CLIXON_DBG_DETAIL, "%d", retval); + clixon_debug(CLIXON_DBG_MSG | CLIXON_DBG_DETAIL, "retval:%d", retval); if (cb) cbuf_free(cb); return retval; diff --git a/lib/src/clixon_proto_client.c b/lib/src/clixon_proto_client.c index 3af83610..57651b64 100644 --- a/lib/src/clixon_proto_client.c +++ b/lib/src/clixon_proto_client.c @@ -253,7 +253,7 @@ clicon_rpc_msg(clixon_handle h, } retval = 0; done: - clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "%d", retval); + clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "retval:%d", retval); if (retdata) free(retdata); if (xret) @@ -1105,7 +1105,7 @@ clicon_rpc_get2(clixon_handle h, } retval = 0; done: - clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "%d", retval); + clixon_debug(CLIXON_DBG_DEFAULT | CLIXON_DBG_DETAIL, "retval:%d", retval); if (nscd) cvec_free(nscd); if (cb) diff --git a/lib/src/clixon_yang_module.c b/lib/src/clixon_yang_module.c index 5cd071c2..86f7c634 100644 --- a/lib/src/clixon_yang_module.c +++ b/lib/src/clixon_yang_module.c @@ -395,7 +395,7 @@ yang_modules_state_get(clixon_handle h, } retval = 1; done: - clixon_debug(CLIXON_DBG_YANG, "%d", retval); + clixon_debug(CLIXON_DBG_YANG, "retval:%d", retval); if (xvec) free(xvec); if (cb)