welterde/l2tpns
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Compare commits

base: welterde:2b13f59f6a2db5ccacc4205a379c2cb53cc47e16
Branches Tags
welterde:master
..
compare: welterde:702ed1ec72a8e6932ba35f4992b2b77eb5a84daa
Branches Tags
welterde:master

2 commits
2b13f59f6a ... 702ed1ec72

Author SHA1 Message Date
Tassilo Schweyer
702ed1ec72 Quick fix to at least decode slightly larger hidden AVPs correctly 2025-05-05 03:15:52 +02:00
Tassilo Schweyer
690e09ba57 Initialize memory so we get zero-terminated string 2025-05-05 03:15:26 +02:00
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
l2tpns.c
View file

@ -4715,6 +4715,7 @@ void processudp(uint8_t *buf, int len, struct sockaddr_in *addr, uint16_t indexu
{ {
if (n <= sizeof(authresp)) if (n <= sizeof(authresp))
{ {
memset(authresp, 0, sizeof(authresp));
memcpy(authresp, b, n); memcpy(authresp, b, n);
authrespn = n; authrespn = n;
LOG(4, s, t, " Proxy Auth Response\n"); LOG(4, s, t, " Proxy Auth Response\n");
@ -8619,6 +8620,10 @@ static void unhide_value(uint8_t *value, size_t len, uint16_t type, uint8_t *vec
size_t d = 0; size_t d = 0;
uint16_t m = htons(type); uint16_t m = htons(type);
// remember first block
uint8_t firstcipher[16];
memcpy(firstcipher, value, 16);
// Compute initial pad // Compute initial pad
MD5_Init(&ctx); MD5_Init(&ctx);
MD5_Update(&ctx, (unsigned char *) &m, 2); MD5_Update(&ctx, (unsigned char *) &m, 2);
@ -8636,7 +8641,7 @@ static void unhide_value(uint8_t *value, size_t len, uint16_t type, uint8_t *vec
{ {
MD5_Init(&ctx); MD5_Init(&ctx);
MD5_Update(&ctx, config->l2tp_secret, strlen(config->l2tp_secret)); MD5_Update(&ctx, config->l2tp_secret, strlen(config->l2tp_secret));
MD5_Update(&ctx, last, sizeof(digest)); MD5_Update(&ctx, firstcipher, sizeof(digest));
MD5_Final(digest, &ctx); MD5_Final(digest, &ctx);
d = 0; d = 0;