From dd98adf3e2b370d843d50a2cedc62fbbe6a1e91f Mon Sep 17 00:00:00 2001 From: Fernando ALVES Date: Sun, 25 Apr 2021 13:47:51 +0200 Subject: [PATCH] Buffer overflow on show sesion pppoe and on pppoe discover LOG level 3. --- util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util.c b/util.c index ff6bf1e..1d512f4 100644 --- a/util.c +++ b/util.c @@ -31,7 +31,8 @@ char *fmtaddr(in_addr_t addr, int n) char *fmtMacAddr(uint8_t *pMacAddr) { - static char strMAC[2*ETH_ALEN]; + // FF:FF:FF:FF:FF:FF (len(18)= 2*6 + 5 (:) + 1 (zero terminal)) + static char strMAC[2*ETH_ALEN+6]; sprintf(strMAC, "%02X:%02X:%02X:%02X:%02X:%02X", pMacAddr[0], pMacAddr[1], pMacAddr[2],