From 81f807eba0ffe10963011d28a18d63bf8cad27bf Mon Sep 17 00:00:00 2001 From: Tassilo Schweyer Date: Mon, 5 May 2025 20:04:18 +0200 Subject: [PATCH] AVP 8 (Vendor Name) should NOT have M-bit set according to RFC --- l2tpns.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/l2tpns.c b/l2tpns.c index 7938d90..7cf553d 100644 --- a/l2tpns.c +++ b/l2tpns.c @@ -4885,7 +4885,7 @@ void processudp(uint8_t *buf, int len, struct sockaddr_in *addr, uint16_t indexu LOG(3, s, t, "sending SCCCN to REMOTE LNS\n"); controlt *c = controlnew(3); // sending SCCCN controls(c, 7, config->multi_n_hostname[tunnel[t].indexudp][0]?config->multi_n_hostname[tunnel[t].indexudp]:hostname, 1); // host name - controls(c, 8, Vendor_name, 1); // Vendor name + controls(c, 8, Vendor_name, 0); // Vendor name control16(c, 2, version, 1); // protocol version control32(c, 3, 3, 1); // framing Capabilities if (sendchalresponse) controlb(c, 13, sendchalresponse, 16, 1); // Challenge response @@ -8815,7 +8815,7 @@ void lac_send_SCCRQ(tunnelidt t, uint8_t * auth, unsigned int auth_len) // Sent SCCRQ - Start Control Connection Request controlt *c = controlnew(1); // sending SCCRQ controls(c, 7, config->multi_n_hostname[tunnel[t].indexudp][0]?config->multi_n_hostname[tunnel[t].indexudp]:hostname, 1); // host name - controls(c, 8, Vendor_name, 1); // Vendor name + controls(c, 8, Vendor_name, 0); // Vendor name control16(c, 2, version, 1); // protocol version control32(c, 3, 3, 1); // framing Capabilities control16(c, 9, t, 1); // assigned tunnel