mirrors/tres
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

openflow/actions: Improve readability of experimenter action codec

Browse source
This commit is contained in:
Eishun Kondoh 2019-07-24 02:38:45 +09:00
parent 6dc3cfd500
commit ca02fe7ed7
1 changed files with 44 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

56
lib/openflow/actions/experimenter.ex
View file

@ -20,28 +20,32 @@ defmodule Openflow.Action.Experimenter do
@spec pack_exp_header(binary()) :: binary() @spec pack_exp_header(binary()) :: binary()
def pack_exp_header(exp_body) do def pack_exp_header(exp_body) do
pad_length = pad_length = pad_length_of(exp_body)
exp_body
|> Kernel.byte_size()
|> Kernel.+(4)
|> Openflow.Utils.padding(8)
length = <<
exp_body 0xFFFF::16,
|> byte_size() length_of(exp_body, pad_length)::16,
|> Kernel.+(4) exp_body::bytes,
|> Kernel.+(pad_length) 0::size(pad_length)-unit(8)
>>
<<0xFFFF::16, length::16, exp_body::bytes, 0::size(pad_length)-unit(8)>>
end end
def read(<<0xFFFF::16, _length::16, exp_id::32, exp_type::16, data::bytes>>) do def read(<<
case Openflow.Utils.get_enum(exp_id, :action_vendor) do 0xFFFF::16,
vendor_id when is_integer(vendor_id) -> _length::16,
%Experimenter{exp_id: exp_id, data: <<exp_type::16, data::bytes>>} exp_id::32,
exp_type::16,
data::bytes
>>) do
exp_id
|> Openflow.Utils.get_enum(:action_vendor)
|> read(exp_id, exp_type, data)
end
vendor when is_atom(vendor) -> ## private functions
case Openflow.Utils.get_enum(exp_type, vendor) do
defp read(vendor_id, exp_id, exp_type, <<data::bytes>>) when is_atom(vendor_id) do
case Openflow.Utils.get_enum(exp_type, vendor_id) do
codec when is_atom(codec) -> codec when is_atom(codec) ->
codec.read(<<exp_id::32, exp_type::16, data::bytes>>) codec.read(<<exp_id::32, exp_type::16, data::bytes>>)
@ -49,5 +53,21 @@ defmodule Openflow.Action.Experimenter do
%Experimenter{exp_id: exp_id, data: <<exp_type::16, data::bytes>>} %Experimenter{exp_id: exp_id, data: <<exp_type::16, data::bytes>>}
end end
end end
defp read(vendor_id, exp_id, exp_type, <<data::bytes>>) when is_integer(vendor_id),
do: %Experimenter{exp_id: exp_id, data: <<exp_type::16, data::bytes>>}
defp pad_length_of(<<exp_body::bytes>>) do
exp_body
|> Kernel.byte_size()
|> Kernel.+(4)
|> Openflow.Utils.padding(8)
end
defp length_of(<<exp_body::bytes>>, pad_length) do
exp_body
|> byte_size()
|> Kernel.+(4)
|> Kernel.+(pad_length)
end end
end end