quality: Add test cases for port_desc and port_stats messages

This commit is contained in:
Eishun Kondoh 2019-05-05 23:37:20 +09:00
parent 2e3f772b1f
commit 599f1947db
8 changed files with 153 additions and 31 deletions

View file

@ -13,10 +13,6 @@ defmodule Openflow.Multipart.PortDesc.Reply do
def ofp_type, do: 18
def new(ports \\ []) do
%Reply{ports: ports}
end
def read(<<ports_bin::bytes>>) do
ports = for <<port_bin::64-bytes <- ports_bin>>, do: Openflow.Port.read(port_bin)
%Reply{ports: Enum.reverse(ports)}

View file

@ -1,4 +1,4 @@
defmodule Openflow.Multipart.PortStats.Reply do
defmodule Openflow.Multipart.Port.Reply do
defstruct(
version: 4,
xid: 0,
@ -13,10 +13,6 @@ defmodule Openflow.Multipart.PortStats.Reply do
def ofp_type, do: 18
def new(ports \\ []) do
%Reply{ports: ports}
end
def read(<<ports_bin::bytes>>) do
ports = Openflow.Multipart.PortStats.read(ports_bin)
%Reply{ports: ports}

View file

@ -1,4 +1,4 @@
defmodule Openflow.Multipart.PortStats.Request do
defmodule Openflow.Multipart.Port.Request do
defstruct(
version: 4,
xid: 0,
@ -12,11 +12,7 @@ defmodule Openflow.Multipart.PortStats.Request do
def ofp_type, do: 18
def new(port_no) when is_integer(port_no) or is_atom(port_no) do
%Request{port_number: port_no}
end
def new(options) when is_list(options) do
def new(options \\ []) do
%Request{
xid: options[:xid] || 0,
port_number: options[:port_no] || :any