quality: Add test cases for meter stats messages

lib/openflow/multipart/meter/request.ex

@@ -12,11 +12,7 @@ defmodule Openflow.Multipart.Meter.Request do
 
   def ofp_type, do: 18
 
-  def new(meter_id) when is_integer(meter_id) or is_atom(meter_id) do
+  def new(options \\ []) do
-    %Request{meter_id: meter_id}
-  end
-
-  def new(options) when is_list(options) do
     %Request{
       xid: options[:xid] || 0,
       meter_id: options[:meter_id] || :all

lib/openflow/multipart/meter_config/request.ex

@@ -1,37 +0,0 @@
-defmodule Openflow.Multipart.MeterConfig.Request do
-  defstruct(
-    version: 4,
-    xid: 0,
-    # virtual field
-    datapath_id: nil,
-    flags: [],
-    meter_id: :all
-  )
-
-  alias __MODULE__
-
-  def ofp_type, do: 18
-
-  def new(meter_id) when is_integer(meter_id) or is_atom(meter_id) do
-    %Request{meter_id: meter_id}
-  end
-
-  def new(options) when is_list(options) do
-    %Request{
-      xid: options[:xid] || 0,
-      meter_id: options[:meter_id] || :all
-    }
-  end
-
-  def read(<<meter_id_int::32, _::size(4)-unit(8)>>) do
-    meter_id = Openflow.Utils.get_enum(meter_id_int, :meter_id)
-    %Request{meter_id: meter_id}
-  end
-
-  def to_binary(%Request{meter_id: meter_id} = msg) do
-    meter_id_int = Openflow.Utils.get_enum(meter_id, :meter_id)
-    body_bin = <<meter_id_int::32, 0::size(4)-unit(8)>>
-    header_bin = Openflow.Multipart.Request.header(msg)
-    <<header_bin::bytes, body_bin::bytes>>
-  end
-end

test/lib/openflow/ofp_meter_stats_test.exs

@@ -0,0 +1,47 @@
+defmodule OfpMeterStatsTest do
+  use ExUnit.Case
+
+  describe "Openflow.Multipart.Meter.Request" do
+    test "with default values" do
+      meter_stats =
+        %Openflow.Multipart.Meter.Request{}
+        |> Map.to_list()
+        |> Openflow.Multipart.Meter.Request.new()
+        |> Openflow.to_binary()
+        |> Openflow.read()
+        |> Kernel.elem(1)
+
+      assert meter_stats.xid == 0
+      assert meter_stats.meter_id == :all
+    end
+  end
+
+  describe "Openflow.Multipart.Meter.Reply" do
+    test "with test packet_data" do
+      meter_stats =
+        "test/packet_data/4-50-ofp_meter_stats_reply.packet"
+        |> File.read!()
+        |> Openflow.read()
+        |> Kernel.elem(1)
+
+      %Openflow.Multipart.Meter.Reply{
+        aux_id: nil,
+        datapath_id: nil,
+        flags: [],
+        meters: [
+          %Openflow.Multipart.Meter{
+            band_stats: [%{byte_band_count: 0, packet_band_count: 0}],
+            byte_in_count: 0,
+            duration_nsec: 480000,
+            duration_sec: 0,
+            flow_count: 0,
+            meter_id: 100,
+            packet_in_count: 0
+}
+        ],
+        version: 4,
+        xid: 0
+      } = meter_stats
+    end
+  end
+end