From c38a648ca4d0d3073be1d84c10746a7be364cd5b Mon Sep 17 00:00:00 2001
From: Olof Hagsand <olof@hagsand.se>
Date: Fri, 10 May 2019 14:44:21 +0000
Subject: [PATCH] wrong fread -1 check

---
 lib/src/clixon_datastore_tree.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/src/clixon_datastore_tree.c b/lib/src/clixon_datastore_tree.c
index 6fc61dd8..179318f6 100644
--- a/lib/src/clixon_datastore_tree.c
+++ b/lib/src/clixon_datastore_tree.c
@@ -206,6 +206,7 @@ buf2xml(FILE      *f,
     int       i;
     uint32_t  ind;
     cxobj    *xc;
+    size_t    ret;
 
     /* Read hdr
      * +-----+-----+-----+-----+-----+-----+-----+-----+
@@ -216,7 +217,7 @@ buf2xml(FILE      *f,
 	clicon_err(OE_UNIX, errno, "fseek");
 	goto done;
     }
-    if (fread(hdr, sizeof(char), sizeof(hdr), f) < 0){
+    if ((ret = fread(hdr, sizeof(char), sizeof(hdr), f)) != sizeof(hdr)){
 	clicon_err(OE_XML, errno, "fread");
 	goto done;
     }
@@ -250,7 +251,7 @@ buf2xml(FILE      *f,
 	clicon_err(OE_UNIX, errno, "malloc");
 	goto done;
     }
-    if (fread(buf, sizeof(char), len-sizeof(hdr), f) < 0){
+    if ((ret = fread(buf, sizeof(char), len-sizeof(hdr), f)) != len-sizeof(hdr)){
 	clicon_err(OE_XML, errno, "fread");
 	goto done;
     }
@@ -318,7 +319,7 @@ xml2buf(FILE      *f,
     int   len1;
     int   ptr;
     int   i;
-    char *buf0;
+    char *buf0 = NULL;
     char *buf;
     uint32_t  myindex;