experiments/clixon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Mem: pagination leak

Browse source
This commit is contained in:
Olof hagsand 2024-10-22 22:47:31 +02:00
parent fd4e694312
commit b39b7dc674
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
apps/backend/backend_get.c
View file

@ -644,6 +644,7 @@ get_list_pagination(clixon_handle h,
cbuf *cbmsg = NULL; /* For error msg */ cbuf *cbmsg = NULL; /* For error msg */
cxobj *xret = NULL; cxobj *xret = NULL;
cxobj **xvec = NULL; cxobj **xvec = NULL;
cxobj **xvec2;
size_t xlen; size_t xlen;
cxobj *x; cxobj *x;
cxobj *xj; cxobj *xj;
@ -807,6 +808,10 @@ get_list_pagination(clixon_handle h,
if (xml_apply(xret, CX_ELMNT, (xml_applyfn_t*)xml_flag_reset, if (xml_apply(xret, CX_ELMNT, (xml_applyfn_t*)xml_flag_reset,
(void*)XML_FLAG_MARK) < 0) (void*)XML_FLAG_MARK) < 0)
goto done; goto done;
if (xvec){
free(xvec);
xvec = NULL;
}
} }
/* then the "sort-by" parameter (see Section 3.1.2) */ /* then the "sort-by" parameter (see Section 3.1.2) */
if (sort_by){ if (sort_by){
@ -818,18 +823,18 @@ get_list_pagination(clixon_handle h,
if (direction && if (direction &&
(x = xpath_first(xret, nsc, "%s", xpath?xpath:"/")) != NULL && (x = xpath_first(xret, nsc, "%s", xpath?xpath:"/")) != NULL &&
(xp = xml_parent(x)) != NULL && (xp = xml_parent(x)) != NULL &&
(xvec = xml_childvec_get(xp)) != NULL){ (xvec2 = xml_childvec_get(xp)) != NULL){
j = xml_child_nr(xp); j = xml_child_nr(xp);
for (i=0; i<j; i++){ for (i=0; i<j; i++){
x = xvec[i]; x = xvec2[i];
if (xml_type(x) != CX_ELMNT) if (xml_type(x) != CX_ELMNT)
continue; continue;
j--; j--;
for (; j>i; j--){ for (; j>i; j--){
xj = xvec[j]; xj = xvec2[j];
if (xml_type(xj) == CX_ELMNT){ if (xml_type(xj) == CX_ELMNT){
xvec[j] = x; xvec2[j] = x;
xvec[i] = xj; xvec2[i] = xj;
} }
break; break;
} }