From b37cec53fb0059cc0fe53676813148769bcdf1a1 Mon Sep 17 00:00:00 2001
From: Jonathan Ben-Avraham <yba@tkos.co.il>
Date: Sat, 14 Nov 2020 21:36:32 +0200
Subject: [PATCH] Added sanity test of TIMEFN

This commit adds a sanity check of the test script TIMEFN, which is by
default 'time -p', for the scripts that define it. The scripts are
currently written such that if there is no 'time' executable, such as in
Debian 9, then some of the scripts fail and some don't but should. This
commit fixes that problem.
---
 test/test_perf_cli.sh        | 2 ++
 test/test_perf_netconf.sh    | 2 ++
 test/test_perf_restconf.sh   | 1 +
 test/test_perf_state.sh      | 1 +
 test/test_perf_state_only.sh | 1 +
 5 files changed, 7 insertions(+)

diff --git a/test/test_perf_cli.sh b/test/test_perf_cli.sh
index 1eed7dce..abcbb08b 100755
--- a/test/test_perf_cli.sh
+++ b/test/test_perf_cli.sh
@@ -19,7 +19,9 @@ s="$_" ; . ./lib.sh || if [ "$s" = $0 ]; then exit 0; else return 0; fi
 # -f %e gives elapsed wall clock time but is not available on all systems
 # so we use time -p for POSIX compliance and awk to get wall clock time
 # Note sometimes time -p is used and sometimes $TIMEFN, cant get it to work same everywhere
+# time function (this is a mess to get right on freebsd/linux)
 : ${TIMEFN:=time -p} # portability: 2>&1 | awk '/real/ {print $2}'
+if ! $TIMEFN true; then err "A working time function" "'$TIMEFN' does not work"; fi
 
 APPNAME=example
 
diff --git a/test/test_perf_netconf.sh b/test/test_perf_netconf.sh
index d523e4b4..441ecc4b 100755
--- a/test/test_perf_netconf.sh
+++ b/test/test_perf_netconf.sh
@@ -20,7 +20,9 @@ s="$_" ; . ./lib.sh || if [ "$s" = $0 ]; then exit 0; else return 0; fi
 # -f %e gives elapsed wall clock time but is not available on all systems
 # so we use time -p for POSIX compliance and awk to get wall clock time
 # Note sometimes time -p is used and sometimes $TIMEFN, cant get it to work same everywhere
+# time function (this is a mess to get right on freebsd/linux)
 : ${TIMEFN:=time -p} # portability: 2>&1 | awk '/real/ {print $2}'
+if ! $TIMEFN true; then err "A working time function" "'$TIMEFN' does not work"; fi
 
 APPNAME=example
 
diff --git a/test/test_perf_restconf.sh b/test/test_perf_restconf.sh
index 49dc2c3a..e6d3c58c 100755
--- a/test/test_perf_restconf.sh
+++ b/test/test_perf_restconf.sh
@@ -21,6 +21,7 @@ s="$_" ; . ./lib.sh || if [ "$s" = $0 ]; then exit 0; else return 0; fi
 # so we use time -p for POSIX compliance and awk to get wall clock time
 # Note sometimes time -p is used and sometimes $TIMEFN, cant get it to work same everywhere
 : ${TIMEFN:=time -p} # portability: 2>&1 | awk '/real/ {print $2}'
+if ! $TIMEFN true; then err "A working time function" "'$TIMEFN' does not work"; fi
 
 APPNAME=example
 
diff --git a/test/test_perf_state.sh b/test/test_perf_state.sh
index 020353d6..6c93787b 100755
--- a/test/test_perf_state.sh
+++ b/test/test_perf_state.sh
@@ -20,6 +20,7 @@ fin=$dir/fin
 
 # time function (this is a mess to get right on freebsd/linux)
 : ${TIMEFN:=time -p} # portability: 2>&1 | awk '/real/ {print $2}'
+if ! $TIMEFN true; then err "A working time function" "'$TIMEFN' does not work"; fi
 
 APPNAME=example
 
diff --git a/test/test_perf_state_only.sh b/test/test_perf_state_only.sh
index 471ed06b..66ae3b18 100755
--- a/test/test_perf_state_only.sh
+++ b/test/test_perf_state_only.sh
@@ -20,6 +20,7 @@ s="$_" ; . ./lib.sh || if [ "$s" = $0 ]; then exit 0; else return 0; fi
 
 # time function (this is a mess to get right on freebsd/linux)
 : ${TIMEFN:=time -p} # portability: 2>&1 | awk '/real/ {print $2}'
+if ! $TIMEFN true; then err "A working time function" "'$TIMEFN' does not work"; fi
 
 APPNAME=example