experiments/clixon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Memory leak/err in notification when closing down

Browse source 
test: restconf notification chunked framing update
This commit is contained in:
Olof hagsand 2022-04-17 13:21:05 +02:00
parent feec3a21d9
commit 600f0616f6
3 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
apps/netconf/netconf_rpc.c
View file

@ -444,7 +444,7 @@ netconf_notification_cb(int s,
struct clicon_msg *reply = NULL;
int eof;
int retval = -1;
cbuf *cb;
cbuf *cb = NULL;
cxobj *xn = NULL; /* event xml */
cxobj *xt = NULL; /* top xml */
clicon_handle h = (clicon_handle)arg;
@ -485,17 +485,22 @@ netconf_notification_cb(int s,
goto done;
/* Send it to listening client on stdout */
if (netconf_output_encap(clicon_option_int(h, "netconf-framing"), cb) < 0){
cbuf_free(cb);
goto done;
}
if (netconf_output(1, cb, "notification") < 0)
if (netconf_output(1, cb, "notification") < 0){
clicon_err(OE_PROTO, ESHUTDOWN, "Socket unexpected close");
close(s);
errno = ESHUTDOWN;
clixon_event_unreg_fd(s, netconf_notification_cb);
goto done;
}
fflush(stdout);
cbuf_free(cb);
ok:
retval = 0;
done:
clicon_debug(1, "%s %d", __FUNCTION__, retval);
if (cb)
cbuf_free(cb);
if (nsc)
xml_nsctx_free(nsc);
if (xt != NULL)