experiments/clixon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* Second fix of https://github.com/clicon/clixon/issues/158

Browse source 
* Actually there is an error of duplicate rpc-replies, but it should be detected in the backend not here
This commit is contained in:
Olof Hagsand 2020-12-06 11:22:26 +00:00
parent 3c014184f7
commit 344dcacf6f
3 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
apps/restconf/restconf_methods_post.c
View file

@ -614,8 +614,13 @@ api_operations_post_output(clicon_handle h,
clicon_debug(1, "%s", __FUNCTION__);
/* Validate that exactly only <rpc-reply> tag with exactly one element child */
if ((xoutput = xml_child_i_type(xret, 0, CX_ELMNT)) == NULL ||
strcmp(xml_name(xoutput),"rpc-reply") != 0 ||
xml_child_nr_type(xoutput, CX_ELMNT) != 1){
strcmp(xml_name(xoutput),"rpc-reply") != 0
/* See https://github.com/clicon/clixon/issues/158
* This is an internal error, they should not be double but the error should not be detected
* here, it should be detected in the backend plugin caller.
|| xml_child_nr_type(xrpc, CX_ELMNT) != 1 XXX backend can have multiple callbacks
*/
){
if (netconf_malformed_message_xml(&xerr, "restconf RPC does not have single input") < 0)
goto done;
if ((xe = xpath_first(xerr, NULL, "rpc-error")) == NULL){