diff --git a/apps/backend/backend_commit.c b/apps/backend/backend_commit.c index e053b62b..31540599 100644 --- a/apps/backend/backend_commit.c +++ b/apps/backend/backend_commit.c @@ -594,15 +594,6 @@ candidate_commit(clicon_handle h, if (xmldb_get0_clear(h, td->td_src) < 0) goto done; - /* Optionally write (potentially modified) tree back to candidate - */ - if (clicon_option_bool(h, "CLICON_TRANSACTION_MOD")){ - if ((ret = xmldb_put(h, candidate, OP_REPLACE, td->td_target, - clicon_username_get(h), cbret)) < 0) - goto done; - if (ret == 0) - goto fail; - } /* 8. Success: Copy candidate to running */ if (xmldb_copy(h, candidate, "running") < 0) @@ -829,14 +820,6 @@ from_client_validate(clicon_handle h, goto done; } - /* Optionally write (potentially modified) tree back to candidate */ - if (clicon_option_bool(h, "CLICON_TRANSACTION_MOD")){ - plugin_transaction_abort_all(h, td); - if ((ret = xmldb_put(h, "candidate", OP_REPLACE, td->td_target, - clicon_username_get(h), cbret)) < 0) - goto done; - goto ok; - } cprintf(cbret, "", NETCONF_BASE_NAMESPACE); /* Call plugin transaction end callbacks */ plugin_transaction_end_all(h, td); diff --git a/apps/restconf/restconf_main_evhtp.c b/apps/restconf/restconf_main_evhtp.c index c0aa0d32..2720c73f 100644 --- a/apps/restconf/restconf_main_evhtp.c +++ b/apps/restconf/restconf_main_evhtp.c @@ -85,7 +85,7 @@ /* Command line options to be passed to getopt(3) */ -#define RESTCONF_OPTS "hD:f:E:l:p:d:y:a:u:ro:bscP:" +#define RESTCONF_OPTS "hD:f:E:l:p:d:y:a:u:ro:" /* See see listen(5) */ #define SOCKET_LISTEN_BACKLOG 16 @@ -587,67 +587,6 @@ cx_get_ssl_client_ca_certs(clicon_handle h, return retval; } -/*! Get Server cert info - * @param[in] h Clicon handle - * @param[in] ssl_verify_clients If true, verify client certs - * @param[out] ssl_config evhtp ssl config struct - */ -static int -cx_get_certs(clicon_handle h, - int ssl_verify_clients, - evhtp_ssl_cfg_t *ssl_config) -{ - int retval = -1; - struct stat f_stat; - char *filename; - - if (ssl_config == NULL){ - clicon_err(OE_CFG, EINVAL, "Input parameter is NULL"); - goto done; - } - if ((filename = clicon_option_str(h, "CLICON_SSL_SERVER_CERT")) == NULL){ - clicon_err(OE_CFG, EFAULT, "CLICON_SSL_SERVER_CERT option missing"); - goto done; - } - if ((ssl_config->pemfile = strdup(filename)) == NULL){ - clicon_err(OE_CFG, errno, "strdup"); - goto done; - } - if (stat(ssl_config->pemfile, &f_stat) != 0) { - clicon_err(OE_FATAL, errno, "Cannot load SSL cert '%s'", ssl_config->pemfile); - goto done; - } - if ((filename = clicon_option_str(h, "CLICON_SSL_SERVER_KEY")) == NULL){ - clicon_err(OE_CFG, EFAULT, "CLICON_SSL_SERVER_KEY option missing"); - goto done; - } - if ((ssl_config->privfile = strdup(filename)) == NULL){ - clicon_err(OE_CFG, errno, "strdup"); - goto done; - } - if (stat(ssl_config->privfile, &f_stat) != 0) { - clicon_err(OE_FATAL, errno, "Cannot load SSL key '%s'", ssl_config->privfile); - goto done; - } - if (ssl_verify_clients){ - if ((filename = clicon_option_str(h, "CLICON_SSL_CA_CERT")) == NULL){ - clicon_err(OE_CFG, EFAULT, "CLICON_SSL_CA_CERT option missing"); - goto done; - } - if ((ssl_config->cafile = strdup(filename)) == NULL){ - clicon_err(OE_CFG, errno, "strdup"); - goto done; - } - if (stat(ssl_config->cafile, &f_stat) != 0) { - clicon_err(OE_FATAL, errno, "Cannot load SSL key '%s'", ssl_config->privfile); - goto done; - } - } - retval = 0; - done: - return retval; -} - static int cx_verify_certs(int pre_verify, evhtp_x509_store_ctx_t *store) @@ -722,9 +661,8 @@ restconf_socket_init(clicon_handle h, clicon_err(OE_UNIX, errno, "socket"); goto done; } - // evutil_make_socket_closeonexec(s); // XXX - // evutil_make_socket_nonblocking(s); // XXX - + evutil_make_socket_closeonexec(s); + evutil_make_socket_nonblocking(s); if (setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, (void *)&on, sizeof(on)) == -1) { clicon_err(OE_UNIX, errno, "setsockopt SO_KEEPALIVE"); goto done; @@ -780,11 +718,7 @@ usage(clicon_handle h, "\t-a UNIX|IPv4|IPv6 Internal backend socket family\n" "\t-u \t Internal socket domain path or IP addr (see -a)\n" "\t-r \t\t Do not drop privileges if run as root\n" - "\t-b \t\t Read config from backend - not local (same as CLICON_RESTCONF_CONF=true) \n" "\t-o